project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Show the image of the entity in the Open Graph Card (from 1781) #41

Open gigamorph opened 4 months ago

gigamorph commented 4 months ago

Problem Description: Sharing LUX links uses the astrolabe image as the open graph card. It would be nice to use the actual LUX image (when available) instead.

**This is a research ticket

Expected Behavior/Solution: Use the associated image (when available) for the Open Graph card image

Requirements: TBD

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples: https://lux-front-tst.collections.yale.edu/view/person/526abc40-ef9f-4053-9520-dd34de408a8c

Dependencies/Blocks:

Related Github Issues:

Related links: BugHerd: https://www.bugherd.com/projects/284041/tasks/1624

Wireframe/Mockup: Current: image

Updated: TBD

kamerynB commented 4 months ago

There are 2 questions to be answered:

  1. Can React update meta tags dynamically? Answer: Yes but I am still unsure of the feasibility within the middle tier. Resources: https://create-react-app.dev/docs/title-and-meta-tags/#generating-dynamic-meta-tags-on-the-server https://blog.logrocket.com/adding-dynamic-meta-tags-react-app-without-ssr/

  2. Is it possible to use IIIF images and wikidata images in open graph meta tags? Answer: Possibly? I believe as long as they are being served from somewhere accessible with an image URL, then we can use them but I have not found concrete evidence that suggests this is possible. However, would there be a problem using wikidata images that require giving credit to the artist/published/the person that owns the image?

kamerynB commented 4 months ago

@prowns Agenda for the 3/7 meeting??

kamerynB commented 3 months ago

Update 3/22: Test out adding the tags dynamically.

kamerynB commented 1 month ago

@prowns @jffcamp @roamye This is something that just needs to be tested in DEV. I can attempt to work on it now.

prowns commented 1 month ago

@kamerynB - fine to work on in DEV. Once it is defined, we can promote.

kamerynB commented 1 month ago

@prowns Why not just promote it then? I'd rather have it in the backlog than placed back into forming.

roamye commented 1 month ago

@kamerynB ---

From the UAT meeting, this is a research tix as it is unsure how this will be implemented. Putting it in forming allows you figure out a solution in DEV. After the proposed solution is added we can then put it into backlog (after reviewing again).

If this is not a research tix, then we would need a mockup of what it is to look like + requirements + how it will be implemented before it could go into backlog.

cc: @prowns