project-lux / lux-frontend

Web front end of LUX
Apache License 2.0
3 stars 0 forks source link

Create event tracking abstraction (from 2016) #78

Closed gigamorph closed 3 months ago

gigamorph commented 8 months ago

Problem Description: Currently the event logging function includes Siteimprove specific code and we want to make it extensible for other university's.

Expected Behavior/Solution: Event logging function will no longer include Siteimprove specific code and will have a placeholder for where university's can add the software of their choice.

Requirements: Siteimprove specific event code is replaced with generic events code.

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

- [ ] Wireframe/Mockup - Heather - [ ] Committee discussions - Sarah - [ ] Feasibility/Team discussion - Sarah - [ ] Backend requirements - TBD -[ ] Frontend requirements- TBD - [ ] Questions

UAT/LUX Examples: What it currently looks like:

pushSiteImproveEvent(
  'Results Tab',
  'Selected',
  tabToLinkLabel[key],
)

What it should look like:

pushClientLogs(
  'Results Tab',
  'Selected',
  tabToLinkLabel[key],
)

Dependencies/Blocks: N/A

Related Github Issues:

Related links: SI Support Tix: https://help.siteimprove.com/support/tickets/3201927

Wireframe/Mockup: N/A

jffcamp commented 8 months ago

From the original ticket: All of the events scattered through the code call into pushSiteImproveEvent(), which is a single function imported from a separate file. So we can just rename the function to pushClientLogs(). Consumers can just update the single function pushClientLogs() to integrate with whatever event tracking system they like.

clarkepeterf commented 7 months ago

Decision from meeting with Rob, Seong, and Peter:

Similar to decision from #77

prowns commented 7 months ago

Blocked - pending conversation regarding need to hook up multiple git repos to Jenkins. @gigamorph to follow up with ITS team.

clarkepeterf commented 6 months ago

This can follow the example of #77, but not enough time to get this change into this release. Pushing to next release

roamye commented 5 months ago

@clarkepeterf is there any way to verify the UAT? or is this done by the developers only?

kamerynB commented 5 months ago

@roamye This hasn't been implemented yet. It is a priority for me this coming milestone. This is related to Site Improve but basically there should be no visible change to the Site Improve tracking.

roamye commented 4 months ago

@kamerynB so it is unreviewable? or are you saying it should be pushed to a different milestone?

kamerynB commented 4 months ago

@roamye Both. I just moved it to the latest milestone. When this change is pushed with the 6/10 milestone, we would just want to ensure Site Improve tracking works the same exact way it did before implementing this.

prowns commented 4 months ago

Per @jffcamp - At SI last meeting: SI is developing event abstraction at their level. Next step - contact SI to see what is planned, when, and then decide if this ticket is still needed. May be able to remove event tracking (not mandatory, but can be done).

@roamye will start support ticket with SI.

roamye commented 4 months ago

Support tix has been made: https://help.siteimprove.com/support/tickets/3201927

and @kamerynB has been CC'd on it.

kamerynB commented 4 months ago

@roamye @jffcamp @prowns Propose that this be closed as it can't be reviewed. The site improve tracking should behave the same as it did before this change.

roamye commented 4 months ago

Approved by UAT

roamye commented 3 months ago

Unreviewable in UAT - Closing.