project-lux / lux-marklogic

Code, issues, and resources related to LUX MarkLogic
Other
3 stars 2 forks source link

Search for Professional Activity type in Advanced Search and Simple Search #156

Open roamye opened 1 month ago

roamye commented 1 month ago

Problem Description: There is no way to search for people or groups with a certain professional activity in Advanced Search/Simple Search.

Expected Behavior/Solution: Create a search for single field "Professional Activity Type" in Advanced Search and facet option in Simple Search.

Requirements:

Learn more about LUX's advanced search capabilities and common search patterns.

View Advanced Search Help

Query:

"type": "Activity",
"classified_as": [
{
"id": "https://lux.collections.yale.edu/data/concept/11c48705-1114-49aa-8896-c7490678b608",
"type": "Type",
"_label": "Professional Activities",
"equivalent": [
{
"id": "http://vocab.getty.edu/aat/300393177",
"type": "Type",
"_label": "Professional Activities"
}
]
},
{
"id": "https://lux.collections.yale.edu/data/concept/904d7773-aa0c-45e5-9db3-71a4eddd2eaa",
"type": "Type",
"_label": "Pharmaceutical industry--United States"
}

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues:

Related links:

Wireframe/Mockup: Have All Of

roamye commented 2 weeks ago

@clarkepeterf is the possible query listed above correct? or will this need a different query for the new facet?

roamye commented 2 weeks ago

added help text - this is TBD & need core team to review.

clarkepeterf commented 1 week ago

@kamerynB Do you want to take this one?

Things you'll need to do:

  1. Update this spreadsheet with the new field: https://docs.google.com/spreadsheets/d/1lwn2tzRNRHtLTPMNWvOsy5fYiIfY4wkthhvgctQ8Hpg/edit#gid=538027221
    • copy existing row and then modify, some colums are auto-generated
    • I think agentTypeId is a good base field to start with and modify
  2. Download as TSV
  3. Put contents of TSV into scripts/generateIndexConf/input.tsv
  4. Run scripts/generateIndexConf/generate.py - this generates a new config/contentDatabaseConfGenerated.json
  5. Update src/main/ml-modules/base/root/config/searchTermConfig.mjs and src/main/ml-modules/base/root/config/userFacingConfig.mjs

Feel free to reach out to me with any questions

kamerynB commented 1 week ago

@clarkepeterf Yes! Sounds good! I'll assign it to me.

kamerynB commented 2 days ago

Notes from 6/26/24 meeting:

  1. The carried_out data point may not always be professional activities, but if it is, it would make things easier.
  2. In the future, assuming 1 might cause problems.
  3. It might be possible to use exclusions in XPath. @kamerynB Will investigate and reach out to @clarkepeterf if necessary.