brent-hartwig commented 2 weeks ago

Problem Description: During 7 Jun 24's performance test (#162), we observed five JS-FATAL instances that were all related to searchWillMatch requests. The logs did not provide any insights on why the request failed or what the search criteria was.

Expected Behavior/Solution:

[x] Pick an existing or new trace event, such as LuxSearch or LuxSearchWillMatch. Selected LuxSearch.
[x] If a new trace event, add to default-group.json. No edit necessary.
[x] Add a try/catch block in determineIfSearchWillMatch. In the catch block, when the selected trace event is enabled, log the request's search criteria and exception.
[x] Update mineBackendLogs.sh to surface failed searchWillMatch requests.

Requirements: See above.

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

~- [] Wireframe/Mockup - Mike~

[x] Committee discussions - Sarah
[x] Feasibility/Team discussion - Sarah
[x] Backend requirements ~- [ ] Frontend requirements~ ~- [ ] Are new regression tests required for QA - Amy~
[x] Compels a performance test? No.
[x] Questions
List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples: Developer will be able to force an error and ensure the log entries are created and picked up by the log mining script.

Dependencies/Blocks: While https://git.yale.edu/lux-its/ml-cluster-formation/issues/19 is not technically blocked by this, I recommend implementing it after this ticket.

Related Github Issues:

183 could be implemented at the same time.

Related links: None.

Wireframe/Mockup: Not needed.

brent-hartwig commented 2 weeks ago

FYI @roamye

xinjianguo commented 4 days ago

@brent-hartwig do we have the strings to monitor yet?

brent-hartwig commented 4 days ago

No, but I can implement this ticket and #183 today. I'll get back to you!

brent-hartwig commented 4 days ago

@xinjianguo, I updated https://git.yale.edu/lux-its/ml-cluster-formation/issues/19 for #177 and https://git.yale.edu/lux-its/ml-cluster-formation/issues/24 for #183 with the text to match on. I'm also adding inline comments on text associated to monitoring tests. cc: @clarkepeterf

brent-hartwig commented 3 days ago

Implemented #177 and #183 together. See PR https://github.com/project-lux/lux-marklogic/pull/197 for implementation details.

project-lux / lux-marklogic

Log additional details of failed searchWillMatch requests #177

183 could be implemented at the same time.