project-lux / lux-marklogic

Code, issues, and resources related to LUX MarkLogic
Other
3 stars 2 forks source link

Remove the personRoles endpoint (from 776) #24

Open gigamorph opened 4 months ago

gigamorph commented 4 months ago

Problem Description: Between the Beta 1 and Beta 2 datasets, the http://www.cidoc-crm.org/cidoc-crm/P14_carried_out_by triples were replaced by https://lux.collections.yale.edu/ns/eventCarriedOutBy triples, yet as explicit in the predicate name, only for events.

The code executed by the personRoles endpoint requires http://www.cidoc-crm.org/cidoc-crm/P14_carried_out_by for people. Unless we want to add them back into the dataset, we cannot facet people by the roles they played as "that information is in the item/work (as above), and hence would require a facet that spans records."

We are not losing functionality offered in the Beta 1 release. One may continue to facet "items/works by people and their role relative to the item/work" as that information is directly in the item and work documents, thereby not require these triples (or any others).

Until removed or the triples added, we may expect this endpoint to return an empty array.

Electing not to use the 'backwards-incompatible' label as neither the front end nor middle tier ever coded against this endpoint.

Scope includes deleting the endpoint, its documentation, and might as well take out utils.getPersonRolesInfo.

Proposed Solution: Remove this endpoint along with other Activity Stream changes.

Testing: try to use endpoint (add test) and make sure it fails.

More info: