project-lux / lux-marklogic

Code, issues, and resources related to LUX MarkLogic
Other
3 stars 2 forks source link

Add Professional Activity Categorized As in Advanced Search #248

Open roamye opened 1 month ago

roamye commented 1 month ago

Problem Description: You can currently search for people or groups with a certain professional activity categorized as in simple search but this ALSO needs to be added to the Advanced Search.

Expected Behavior/Solution: Add the search functionality and a new single field Professional Activity Categorized As in Advanced Search which accepts other fields and include new Help Text.

Requirements:

Search for people and groups that carried out professional activities of the given categorization.

Learn more about LUX's advanced search capabilities and common search patterns.

View Advanced Search Help



**Needed for promotion:**
If an item on the list is not needed, it should be crossed off but not removed.

- [x] Wireframe/Mockup - Mike
- [x] Committee discussions - Sarah
- [x] Feasibility/Team discussion - Sarah
- [x] Backend requirements - TBD
- [ ] Frontend requirements- Kam
- [ ] Are new regression tests required for QA - Amy
- [x] Questions
- List of questions for discussions. Answers should be documented within the issue.

**UAT/LUX Examples:**

- AS for professional activity type of Pharamaceutical Industry should show a results page include the record below: 
- https://lux.collections.yale.edu/view/group/2e68492c-ef49-46ac-ad1a-4960ff46986d

**Dependencies/Blocks:**

- Blocked By: Issues that are blocking the completion of the current issue.
- Blocking: Issues being blocked by the completion of the current issue.

**Related Github Issues:**
- https://github.com/project-lux/lux-marklogic/issues/156

**Related links:**

- Bugherd: https://www.bugherd.com/projects/284041/tasks/2231

**Wireframe/Mockup:**
![example1_1](https://github.com/project-lux/lux-frontend/assets/163148482/7477b25c-5b9d-454e-b58d-b297d58dcc02)
roamye commented 1 month ago

@clarkepeterf - is this a quick fix? If it is we can add it to the next milestone 08/19

clarkepeterf commented 1 month ago

In order for this to become a field that can work with other terms inside it (Name, Anywhere, Broader Concept, etc.) we will need a new triple relating Agents and their Professional Activities. Is that something we can add @kkdavis14?

kkdavis14 commented 1 month ago

I am struggling to find an example that exists for this type of data. Usually Professional Activities is a timespan or a location, which you can search for in AS. The example in the ticket doesn't exist like that anymore, as it was incorrect data.

clarkepeterf commented 3 weeks ago

@kkdavis14 For example - this record has the following in its JSON, meaning they have a Professional Activity categorized as Education:

"carried_out": [
    {
        "type": "Activity",
        "classified_as": [
            {
                "id": "https://lux-front-tst.collections.yale.edu/data/concept/11c48705-1114-49aa-8896-c7490678b608",
                "type": "Type",
                "_label": "Professional Activities",
                "equivalent": [
                    {
                        "id": "http://vocab.getty.edu/aat/300393177",
                        "type": "Type",
                        "_label": "Professional Activities"
                    }
                ]
            },
            {
                "id": "https://lux-front-tst.collections.yale.edu/data/concept/3a30298b-37ce-40dd-aae4-4587994c54ba",
                "type": "Type",
                "_label": "Education"
            }
        ]
    }
]

If you search for People & Groups you can see a facet for Professional Activity Categorized As. If you select one of those facets, then each result should have an example like this in its data.

Screenshot 2024-08-16 at 11 00 28 AM

Can this be turned into a triple?

kkdavis14 commented 3 weeks ago

yep https://github.com/project-lux/data-pipeline/issues/119

clarkepeterf commented 3 weeks ago

@roamye This will have to move to a future sprint, after https://github.com/project-lux/data-pipeline/issues/119 is completed

roamye commented 3 weeks ago

@clarkepeterf - sounds good, adding the 09/09 milestone as a check-in. We can move it again if needed.

kkdavis14 commented 1 week ago

@clarkepeterf I was incorrect about the bug--the triple already exists: subject: Agent > property: "https://lux.collections.yale.edu/ns/typeOfProfessionalActivity" > object: classificationID

clarkepeterf commented 1 week ago

@kkdavis14 I still don't see that triple in this example record - it has the following JSON, meaning this person has a Professional Activity categorized as Education:

"carried_out": [
    {
        "type": "Activity",
        "classified_as": [
            {
                "id": "https://lux-front-tst.collections.yale.edu/data/concept/11c48705-1114-49aa-8896-c7490678b608",
                "type": "Type",
                "_label": "Professional Activities",
                "equivalent": [
                    {
                        "id": "http://vocab.getty.edu/aat/300393177",
                        "type": "Type",
                        "_label": "Professional Activities"
                    }
                ]
            },
            {
                "id": "https://lux-front-tst.collections.yale.edu/data/concept/3a30298b-37ce-40dd-aae4-4587994c54ba",
                "type": "Type",
                "_label": "Education"
            }
        ]
    }
]

But there is not a typeOfProfessionalActivity triple in this document

clarkepeterf commented 1 week ago

@kkdavis14 looks like that triple is in the new 2024-08-29 dataset in SBX. This can be unblocked for next release. Marking for 09-23 @roamye