project-lux / lux-marklogic

Code, issues, and resources related to LUX MarkLogic
Other
3 stars 2 forks source link

Update place relatedToConcept to remove Place of Publication relationship. #284

Closed roamye closed 3 weeks ago

roamye commented 3 months ago

Problem Description: Place of Publication and Published At this Place relationships are not desired in Related Lists. ~https://github.com/project-lux/lux-frontend/issues/343~, the related lists will need to be updated.

Expected Behavior/Solution: Place of publication will no longer be a part of the related list: https://lux-front-tst.collections.yale.edu/api/related-list/place?name=relatedToConcept&uri=https%3A%2F%2Flux.collections.yale.edu%2Fdata%2Fconcept%2Fd067d500-e6ea-4da2-9a2d-18bcd58e21dc

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks: N/A

Related Github Issues:

Related links:

Wireframe/Mockup: Current: image

Updated: image

clarkepeterf commented 1 month ago

@azaroth42 @roamye

I have a couple of questions:

  1. The ticket explicitly mentions removing "Place of Publication" relationships from the Related Locations list on Concept pages. Do we also want to remove them from the Related Locations list on Agent and Place pages?
  2. Do we want to also remove "Published At" relationships on Place pages? E.g. on the page for New York:
    • Screenshot 2024-10-09 at 11 34 57 AM
roamye commented 1 month ago

@clarkepeterf - bringing this to uat discussion tomorrow. will update you with answers afterwards.

azaroth42 commented 1 month ago

IMO remove all place-of-publications from all related lists.

clarkepeterf commented 1 month ago

@azaroth42 Thanks, I'm going to interpret this as a yes to both 1 and 2 from my comment above.

roamye commented 1 month ago

Approved by UAT

roamye commented 3 weeks ago

Looks good in prod. closing.