project-lux / lux-marklogic

Code, issues, and resources related to LUX MarkLogic
Other
3 stars 2 forks source link

Fix Incorrectly Configured Fields - idIndexReferences #301

Closed clarkepeterf closed 1 month ago

clarkepeterf commented 2 months ago

Problem Description: Per this comment

Some search terms have their idIndexReferences property incorrectly configured as an array. This is not causing any functional problems right now, but has potential to in the future.

Expected Behavior/Solution:

the idIndexReferences for the search terms mentioned in this comment should be changed to be an array.

The app should continue to function as expected.

Requirements:

Needed for promotion:

- [ ] Wireframe/Mockup - Mike - [ ] Committee discussions - Sarah - [ ] Feasibility/Team discussion - Sarah - [ ] Backend requirements - TBD - [ ] Frontend requirements- TBD - [ ] Are new regression tests required for QA - Amy - [ ] Questions - List of questions for discussions. Answers should be documented within the issue.

UAT/LUX Examples:

Dependencies/Blocks:

- Blocked By: Issues that are blocking the completion of the current issue. - Blocking: Issues being blocked by the completion of the current issue.

Related Github Issues:

-https://github.com/project-lux/lux-marklogic/issues/74

Related links:

Wireframe/Mockup:

brent-hartwig commented 1 month ago

@jffcamp and @prowns, this is a five minute branch-thru-merged-PR fix; until fixed, the check predicates script errors out (#306).

jffcamp commented 1 month ago

Ah, so amongst other things, this will be good to do before the next dataset. @brent-hartwig I've updated to reflect the next milestone.

roamye commented 1 month ago

@clarkepeterf - once this is in PROD, who would be best to review that the idIndexReferences are an array?

roamye commented 1 month ago

Approved by UAT 9/27, but please see comment above.

clarkepeterf commented 1 month ago

@roamye The fields have all been updated such that their idIndexReferences property is an array. See here:

Screenshot 2024-10-07 at 10 14 28 AM

roamye commented 1 month ago

perfect. closing this :)