project-lux / lux-middletier

Node backend for LUX frontend (a.k.a. middle tier)
Apache License 2.0
2 stars 0 forks source link

Update Work Related query to include the search for Works With this Concept Component term #85

Closed roamye closed 4 weeks ago

roamye commented 1 month ago

Problem Description: The HAL Link for the Works Related tab needs to be updated to also search for works with the concept component term as it currently does not search for this.

Expected Behavior/Solution: The Works Related tab will include search results for works related AND works with this concept component term.

Requirements:

Needed for promotion: If an item on the list is not needed, it should be crossed off but not removed.

UAT/LUX Examples:

Dependencies/Blocks:

Related Github Issues: N/A

Related links: N/A

roamye commented 1 month ago

This ticket needs to be updated to include the query name.

roamye commented 1 month ago

7/30 TF: Search Terms: ConceptsInfluencedByConcepts.

@clarkepeterf - to look for other search terms.

kamerynB commented 1 month ago

@clarkepeterf Please confirm that the following search will be used for this HAL link: https://lux-front-dev.collections.yale.edu/view/results/concepts?q=%7B%22AND%22%3A%5B%7B%22influencedByConcept%22%3A%7B%22id%22%3A%22https%3A%2F%2Flux.collections.yale.edu%2Fdata%2Fconcept%2F12927247-87b8-43a3-a12d-ff3cd7082324%22%7D%7D%5D%7D

Second part to this question: Is this relationship going to be added to the Works Related query or will it be its own tab? @roamye

roamye commented 1 month ago

After discussion with @kamerynB - this relationship is not to be added to the Works Related query as we are adding a new tab to search for Works with this Concept Component Term and NOT modifying the Works Related tab. This requires a different HAL LINK. which Kam will add to the ticket once it is discovered. The issue above has been updated.

kamerynB commented 1 month ago

Sorry, there was a lot of confusion with this ticket on my part. The relationship will be added to the existing Works Related HAL link and tab (on the frontend). @roamye

roamye commented 1 month ago

@kamerynB/ @clarkepeterf - for the UAT link listed above... the record "The reward cruelty" is a works related under Satires England 1900 but does not show up under the Works related under the Satires component term. Is there an issue? or is this supposed to happen?

clarkepeterf commented 1 month ago

@roamye "The reward of cruelty" is a result in that tab for "Satires" now, but it can only be seen if you click the "Show all 11473 results" link.

To see it, follow the link, then under the Created By facet, select William Hogarth. Then go to page 11. It is the 14th result on that page. Link directly to that results page here

roamye commented 1 month ago

@clarkepeterf thanks Peter! I clicked the wrong facet which is why I could not find the record. I can see the record now from ur instructions.

roamye commented 1 month ago

Approved by UAT 8/7

roamye commented 4 weeks ago

Looks good in PROD. Closing