search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Zero logical volumes during lvcreate. #104

Closed smoser closed 3 years ago

smoser commented 3 years ago

lvcreate defaults to not zeroing devices if called the way we are calling it (--yes --activate=y --setactivationskip=n). That seems very odd.

Without zero'ing, it seems that eventually the user will create a volume that has data on it that is problematic.

codecov[bot] commented 3 years ago

Codecov Report

Merging #104 (5e4fac2) into master (4bfa793) will increase coverage by 2.54%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   64.13%   66.68%   +2.54%     
==========================================
  Files          16       16              
  Lines        1712     1987     +275     
==========================================
+ Hits         1098     1325     +227     
- Misses        445      491      +46     
- Partials      169      171       +2
Impacted Files Coverage Δ
linux/lvm.go 52.91% <50.00%> (+2.49%) :arrow_up:
linux/virt.go 80.00% <0.00%> (-6.96%) :arrow_down:
guid.go 100.00% <0.00%> (ø)
partid/partid.go 0.00% <0.00%> (ø)
megaraid/linux.go 0.00% <0.00%> (ø)
mockos/lvm.go 98.90% <0.00%> (+0.16%) :arrow_up:
mockos/system.go 87.75% <0.00%> (+1.26%) :arrow_up:
linux/system.go 38.79% <0.00%> (+1.29%) :arrow_up:
lvm.go 77.77% <0.00%> (+1.58%) :arrow_up:
util.go 89.28% <0.00%> (+1.78%) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4bfa793...5e4fac2. Read the comment docs.