search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Update and fix golangci-lint issues #107

Closed raharper closed 2 years ago

codecov[bot] commented 3 years ago

Codecov Report

Merging #107 (746c023) into master (e570cde) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   67.92%   67.90%   -0.02%     
==========================================
  Files          16       16              
  Lines        1989     1988       -1     
==========================================
- Hits         1351     1350       -1     
  Misses        464      464              
  Partials      174      174
Impacted Files Coverage Δ
linux/lvm.go 62.68% <ø> (ø)
disk.go 77.83% <100.00%> (ø)
linux/disk.go 57.14% <100.00%> (ø)
linux/lvmdump.go 73.25% <100.00%> (-0.31%) :arrow_down:
linux/virt.go 80.00% <100.00%> (ø)
megaraid/storcli.go 68.82% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e570cde...746c023. Read the comment docs.

raharper commented 3 years ago

How about this change, which puts the definition of the golangci version in Makefile, adds a rule to install it, and then uses that (./tools/golangci-lint-v1.30.0) everywhere.

Sure, let me try pulling this in.

smoser commented 2 years ago

I added to this at https://github.com/anuvu/disko/pull/110. I'm going to close this one, @raharper please review the other.