search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Do not allow creation of a GPT partition without a guid. #108

Closed smoser closed 2 years ago

smoser commented 3 years ago

If the user called CreatePartition with a partition that had an empty ID, then it would be created with an empty id.

That is almost certainly not the desired behavior. In that case, generate an ID.

codecov[bot] commented 3 years ago

Codecov Report

Merging #108 (6d5d3b7) into master (e570cde) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   67.92%   67.97%   +0.04%     
==========================================
  Files          16       16              
  Lines        1989     1992       +3     
==========================================
+ Hits         1351     1354       +3     
  Misses        464      464              
  Partials      174      174
Impacted Files Coverage Δ
linux/disk.go 57.42% <100.00%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e570cde...6d5d3b7. Read the comment docs.