project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Feature/better Details output. #114

Closed smoser closed 2 years ago

smoser commented 2 years ago

4 things here (see commits):

codecov[bot] commented 2 years ago

Codecov Report

Merging #114 (af21993) into master (fd8c813) will increase coverage by 0.15%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
+ Coverage   67.17%   67.32%   +0.15%     
==========================================
  Files          16       16              
  Lines        2111     2118       +7     
==========================================
+ Hits         1418     1426       +8     
  Misses        505      505              
+ Partials      188      187       -1     
Impacted Files Coverage Δ
partid/partid.go 0.00% <ø> (ø)
disk.go 77.52% <91.66%> (+1.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd8c813...af21993. Read the comment docs.

smoser commented 2 years ago

I'm going to go ahead and merge. I do think both Serge and Ryan had valid inputs. I'm largely claiming two things make it OK for me to change output:

The one use case that Ryan pointed is not broken by this.