project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Add support for smartpqi #130

Closed raharper closed 9 months ago

raharper commented 9 months ago

Add support for smartpqi/arcconf RAID adapters on Linux

The smartpqi driver for Adaptec/Microsemi RAID controllers uses a cli tool called arcconf. Add support modeled after the existing MegaRAID/storcli structures and implement the RAID Controller interface introduced to abstract the specific RAID adapter for the linux system.

Signed-off-by: Ryan Harper ryaharpe@cisco.com

codecov[bot] commented 9 months ago

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (82804d0) 66.86% compared to head (eabe011) 65.78%.

Files Patch % Lines
smartpqi/arcconf.go 69.37% 86 Missing and 12 partials :warning:
linux/util.go 15.15% 28 Missing :warning:
megaraid/storcli.go 0.00% 21 Missing :warning:
smartpqi/smartpqi.go 29.62% 18 Missing and 1 partial :warning:
linux/system.go 26.31% 13 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #130 +/- ## ========================================== - Coverage 66.86% 65.78% -1.09% ========================================== Files 16 17 +1 Lines 2161 2531 +370 ========================================== + Hits 1445 1665 +220 - Misses 520 667 +147 - Partials 196 199 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hallyn commented 9 months ago

Thanks - it looks good to me. Did you want to rebase or merge as is (with or without the 3 error messages updated)?

raharper commented 9 months ago

Thanks - it looks good to me. Did you want to rebase or merge as is (with or without the 3 error messages updated)?

I'll address your comment and rebase/squash into 3 commits (and fix the lint error I somehow missed)