Closed raharper closed 9 months ago
Attention: 180 lines
in your changes are missing coverage. Please review.
Comparison is base (
82804d0
) 66.86% compared to head (eabe011
) 65.78%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks - it looks good to me. Did you want to rebase or merge as is (with or without the 3 error messages updated)?
Thanks - it looks good to me. Did you want to rebase or merge as is (with or without the 3 error messages updated)?
I'll address your comment and rebase/squash into 3 commits (and fix the lint error I somehow missed)
Add support for smartpqi/arcconf RAID adapters on Linux
The smartpqi driver for Adaptec/Microsemi RAID controllers uses a cli tool called
arcconf
. Add support modeled after the existing MegaRAID/storcli structures and implement the RAID Controller interface introduced to abstract the specific RAID adapter for the linux system.Did not implement the Caching mechansim, repeated invocations do not have any significant impact on system, 5 minute timeout seems quite long to wait for RAID device changes which happen immediately after issuing arcconf commands.
Refactored how linux package looks up disks to see if they belong to a RAID adapter to prevent import loops.
Added tests for arcconf for the interface commands parsing output collected from systems with smartpqi driver and card
Added smartpqi to the demo program
Signed-off-by: Ryan Harper ryaharpe@cisco.com