search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Fix regression where non-raid attached disks did not determine correct disk type #133

Closed raharper closed 9 months ago

raharper commented 9 months ago

The raid controller merge regressed the path for non-raid attached disks and all such disks were classified as HDDs. This was found under KVM testing where disko uses a prefix in the ID_SERIAL property to set the disk type to SSD.

codecov[bot] commented 9 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7b7d307) 65.38% compared to head (749ccdd) 66.02%.

Files Patch % Lines
linux/system.go 50.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ========================================== + Coverage 65.38% 66.02% +0.64% ========================================== Files 17 17 Lines 2551 2555 +4 ========================================== + Hits 1668 1687 +19 + Misses 683 661 -22 - Partials 200 207 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.