search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Finish Lvm Impl #16

Closed smoser closed 4 years ago

smoser commented 4 years ago

This finishes the implementation of lvm interface by adding CreateLV, ExtendLV, HasLV, RemoveLV.

Notes:

Also adds Ceiling and Floor functions that can be used in calling CreateLV and ExtendLV.

createLv("vg0", "lv0", Ceiling(mysize, lvm.ExtentSize) lvm.THICK)
codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will increase coverage by 7.09%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   43.95%   51.04%   +7.09%     
==========================================
  Files          10       11       +1     
  Lines         860      907      +47     
==========================================
+ Hits          378      463      +85     
+ Misses        469      427      -42     
- Partials       13       17       +4
Impacted Files Coverage Δ
linux/disk.go 13.79% <ø> (+1.19%) :arrow_up:
linux/lvm.go 6.77% <0%> (-1.23%) :arrow_down:
linux/system.go 0% <0%> (ø) :arrow_up:
disk.go 88.67% <100%> (+83.67%) :arrow_up:
linux/virt.go 73.33% <69.23%> (+73.33%) :arrow_up:
linux/util.go 66.93% <83.33%> (+4.61%) :arrow_up:
util.go 87.5% <87.5%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d942ec8...49abf5a. Read the comment docs.