search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Feature/add some implementation #2

Closed smoser closed 4 years ago

smoser commented 4 years ago

This is some initial implementation as moved over from elsewhere.

I'm interested in feedback on the DiskImpl (name) and convention of implementation and such.

I do have some tests to move over still, and what is here probably isn't even complete, but would like some feedback.

rchamarthy commented 4 years ago

@smoser rebase your PR latest origin/master and the code coverage should work.

codecov[bot] commented 4 years ago

Codecov Report

Merging #2 into master will decrease coverage by 6.18%. The diff coverage is 0.49%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #2      +/-   ##
=========================================
- Coverage    6.66%   0.48%   -6.19%     
=========================================
  Files           3       5       +2     
  Lines          30     416     +386     
=========================================
  Hits            2       2              
- Misses         28     414     +386
Impacted Files Coverage Δ
util.go 0% <0%> (ø)
virt.go 0% <0%> (ø)
disk.go 0.69% <0.69%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 54c2e05...34e27f0. Read the comment docs.