search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Change 'End' to 'Last' in Partition, and clarify bytes in doc. #20

Closed smoser closed 4 years ago

smoser commented 4 years ago

The use of 'End' can be confusing. If a partition has Start: 512 End: 1023 It is not obvious whether or not the Partition includes byte 1023. It is more obvious if we use 'Last'.

codecov[bot] commented 4 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is 89.47%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #20   +/-   ##
=======================================
  Coverage   54.95%   54.95%           
=======================================
  Files          12       12           
  Lines         999      999           
=======================================
  Hits          549      549           
  Misses        430      430           
  Partials       20       20
Impacted Files Coverage Δ
linux/disk.go 13.79% <0%> (ø) :arrow_up:
util.go 89.28% <100%> (ø) :arrow_up:
disk.go 86.2% <88.88%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 175ba6e...f0bcfd0. Read the comment docs.