search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Wipe Please #33

Closed smoser closed 4 years ago

smoser commented 4 years ago

3 commits here related to wiping.

a.) Explicitly zero lvm objects when created or initialized. b.) Zero start and end of a to-be-created partition addPartitionSet. c.) Implement linux system Wipe.

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into master will decrease coverage by 0.70%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
- Coverage   60.49%   59.78%   -0.71%     
==========================================
  Files          14       14              
  Lines        1382     1415      +33     
==========================================
+ Hits          836      846      +10     
- Misses        488      504      +16     
- Partials       58       65       +7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b69beb...26af880. Read the comment docs.

smoser commented 4 years ago

@rchamarthy If you want to insist on better test coverage here, I can improve slightly witha little work, but most of what is missing is a.) the lvm changes to use '--wipe' b.) the error paths

those are not easily covered. :-(