search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Connect megaraid to linux System. #37

Closed smoser closed 4 years ago

smoser commented 4 years ago

This connects the linux disko.System() interface with a storCli implementation. The end result is that now we get improved answers for the DiskType of a Disk. If the disk is a virtual megaraid drive whose DiskGroup is entirely made up of ssd, then you will now see that its DiskTypetype is SSD.

It is hooked up through go-cache to avoid repeated queries of 'storcli'. That isn't slow, but not fast either. The assumption is that those things dont' change very often. The timeout is set to 5 minutes here.

codecov[bot] commented 4 years ago

Codecov Report

Merging #37 into master will decrease coverage by 1.16%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
- Coverage   61.49%   60.32%   -1.17%     
==========================================
  Files          14       14              
  Lines        1444     1472      +28     
==========================================
  Hits          888      888              
- Misses        495      523      +28     
  Partials       61       61

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8b9b01...1564344. Read the comment docs.