fix CreatePV to use name and path

[rchamarthy]

CreatePV accepts a path but thinks it can accept a name and uses the param as a name to later find the PV it just created. The scan fails to match and CreatePV always returns an error saying it did not find the PV it just successfully created.

Fix: accept name or path, if name is given make a path and if path is given make a name and then use both appropriately

Signed-off-by: Ravi Chamarthy ravchama@cisco.com

[codecov[bot]]

Codecov Report

Merging #51 into master will decrease coverage by 0.35%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   57.37%   57.01%   -0.36%     
==========================================
  Files          15       15              
  Lines        1607     1617      +10     
==========================================
  Hits          922      922              
- Misses        618      628      +10     
  Partials       67       67              

Impacted Files	Coverage Δ
linux/lvm.go	9.01% <0.00%> (-0.41%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4124c14...cdbeb48. Read the comment docs.

[smoser]

I do want to get this fix in, because it is clearly broken. so... please respond and lets get that done.

[rchamarthy]

@smoser that diff looks good to me, I have to change my code in storaged and storagectl to make these names. I had to work around and make it a path. I took the route to keep it compatible with my codebase but this is fine too. Its a small change on my side.

[smoser]

https://github.com/anuvu/disko/pull/52

closing this one for that.