search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Return error in CreateVG when command or scan fails. #60

Closed smoser closed 4 years ago

smoser commented 4 years ago

CreateVG was not returning error even when it detected one.

codecov[bot] commented 4 years ago

Codecov Report

Merging #60 into master will not change coverage by %. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   56.54%   56.54%           
=======================================
  Files          15       15           
  Lines        1657     1657           
=======================================
  Hits          937      937           
  Misses        651      651           
  Partials       69       69
Impacted Files Coverage Δ
linux/lvm.go 8.57% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6591a09...51c1f13. Read the comment docs.