project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

refactor into linux specific implementation #7

Closed rchamarthy closed 4 years ago

rchamarthy commented 4 years ago

Define high level system interface that allows us to provide multiple implementaitons for the disko API.

Refactor the existing disk implementation into a linux specific implementation.

Signed-off-by: Ravi Chamarthy ravchama@cisco.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #7 into master will increase coverage by 0.26%. The diff coverage is 0.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   10.57%   10.83%   +0.26%     
==========================================
  Files           5        6       +1     
  Lines         416      406      -10     
==========================================
  Hits           44       44              
+ Misses        370      360      -10     
  Partials        2        2
Impacted Files Coverage Δ
disk.go 50% <ø> (+49.3%) :arrow_up:
linux/virt.go 0% <ø> (ø)
vg.go 0% <ø> (ø) :arrow_up:
linux/lvm.go 0% <0%> (ø)
linux/disk.go 0% <0%> (ø)
linux/util.go 42.85% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e89794a...09f110f. Read the comment docs.

smoser commented 4 years ago

"multiple implementations" I think is a bit early to worry about. I can see that a mock implementation can be useful for test, but I have no intention of worrying about anything other than linux at this point.

rchamarthy commented 4 years ago

Of course! This if for mockos.