search

project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

simplify api to system and lvm #8

Closed rchamarthy closed 4 years ago

rchamarthy commented 4 years ago

Simpify api to just system and lvm interfaces and have the rest of the constructs are structs.

Interfaces: System, VolumeManager Structs: Disk, Partition, VG, LV, PV

This allows for all the structs and the corresponding methods to be reused by mock implementation. All the platform specific methods are modeled in the interfaces and can be implemented per platform.

Signed-off-by: Ravi Chamarthy ravchama@cisco.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.08%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #8      +/-   ##
==========================================
+ Coverage   10.83%   10.91%   +0.08%     
==========================================
  Files           6        6              
  Lines         406      403       -3     
==========================================
  Hits           44       44              
+ Misses        360      357       -3     
  Partials        2        2
Impacted Files Coverage Δ
linux/lvm.go 0% <0%> (ø) :arrow_up:
disk.go 5% <0%> (-45%) :arrow_down:
lvm.go 0% <0%> (ø)
linux/disk.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c9cbb67...de6ca67. Read the comment docs.