project-machine / disko

Disk Operations API in Go
Apache License 2.0
13 stars 9 forks source link

Support failure if integration tests cannot run. #88

Closed smoser closed 4 years ago

smoser commented 4 years ago

Previously intergration tests would just Skip() if they did not have the necessary tools to run. That could lead to a situation where we don't realize the tests are not running and happily trust c-i that was not running integration tests.

Here, we let the behavior be controlled by DISKO_INTEGRATION environment variable.

Also, we set DISKO_INTEGRATION=run in c-i, so failures will fail.

codecov[bot] commented 4 years ago

Codecov Report

Merging #88 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #88   +/-   ##
=======================================
  Coverage   66.23%   66.23%           
=======================================
  Files          16       16           
  Lines        1937     1937           
=======================================
  Hits         1283     1283           
  Misses        487      487           
  Partials      167      167           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9f0686...4a1e996. Read the comment docs.