search

project-machine / machine

Apache License 2.0
12 stars 7 forks source link

add machine client api pkg #27

Closed hallyn closed 1 year ago

hallyn commented 1 year ago

Add a client API to get and put a machine. This is used by trust to edit a machine's boot source, iso and disks.

raharper commented 1 year ago

Looking at cmd/machine/cmd/root.go; the private methods are:

getMachines getMachine postMachine putMachine

And this PR makes only Get and Put machine ... shouldn't the client API include all of these?

for example, machine init uses postMachine

console does a Post to the machines//console URL .

Do you see adding those after this? or should they all go in now?

hallyn commented 1 year ago

I figured we'd add them as they're needed, but I don't mind either way. I can add them now if you like.