project-machine / puzzlefs

Apache License 2.0
380 stars 18 forks source link

Pass mount options to puzzlefs with the -o flag #65

Closed ariel-miculas closed 1 year ago

ariel-miculas commented 1 year ago

Possible options: auto_unmount allow_other allow_root default_permissions dev nodev suid nosuid ro rw exec noexec atime noatime dirsync sync async fsname= subtype=

It supports comma separated values and multiple -o flags.

Example: puzzlefs mount -o ro,allow_other ... puzzlefs mount -o ro -o allow_other ...

Fixes #62

Signed-off-by: Ariel Miculas amiculas@cisco.com

ariel-miculas commented 1 year ago
$ target/debug/puzzlefs mount -f /tmp/oci-simple first_try /tmp/puzzle
$ mount | rg /tmp/puzzle
/dev/fuse on /tmp/puzzle type fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000)

By default, the allow_other flag is not set. Only when passing it explicitly it gets set:

$ target/debug/puzzlefs mount -o allow_other -f /tmp/oci-simple first_try /tmp/puzzle
$ mount | rg /tmp/puzzle
/dev/fuse on /tmp/puzzle type fuse (rw,nosuid,nodev,relatime,user_id=1000,group_id=1000,allow_other)

Or is that not actually what we want?

I'm not sure what you mean, should allow_other be a default option? Is your system setting the allow_other flag by default?

hallyn commented 1 year ago

I'm not sure what you mean, should allow_other be a default option? Is your system setting the allow_other flag by default?

That's what I'm asking :)