project-nv / night-vision

Highly customizable charting library, created for professional traders
https://nightvision.dev
MIT License
250 stars 58 forks source link

Non-passive event listner to a scroll-blocking 'wheel' event. #28

Closed frbju closed 1 year ago

frbju commented 1 year ago

Describe the bug

night-vision.js:5902 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952 evt

Possible solution

https://github.com/angular/components/issues/4221#issuecomment-299872704

Reproduction

x

Steps to reproduce

x

Javascript Framework

svelte

Logs

night-vision.js:5902 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952

Validations

C451 commented 1 year ago

Do you get it in Chrome? This is warning from hamsterjs lib, so requires too much action to fix. Maybe in the future.

frbju commented 1 year ago

Chrome is correct 👍. Sounds good, in my understanding it does not really affect the performance either.