project-nv / night-vision

Highly customizable charting library, created for professional traders
https://nightvision.dev
MIT License
250 stars 58 forks source link

Update types.ts #37

Closed Swoorup closed 1 year ago

Swoorup commented 1 year ago
netlify[bot] commented 1 year ago

Deploy Preview for shiny-selkie-5e063f canceled.

Name Link
Latest commit 40b64533bf512ce391cde573c4bb2e71bc5d0aa0
Latest deploy log https://app.netlify.com/sites/shiny-selkie-5e063f/deploys/63b29ac026bc5f00082a528c
Swoorup commented 1 year ago

Why "Spline" | "Candles" | string; instead of string? It can be literally any type/

Discoverability, and autocompletion of the built-in types. Even though "Spline" | "Candles" | string; is the same as string, ides can give you hints on what the possible types are.

Btw I have changed such that you have BuiltInCandleOverlay which restricts both the type and the shape of the data later.

Swoorup commented 1 year ago
image
C451 commented 1 year ago

Ok, will look into