project-oak / silveroak

Formal specification and verification of hardware, especially for security and privacy.
Apache License 2.0
123 stars 20 forks source link

Fix and comment SHA256 circuit #908

Closed blaxill closed 3 years ago

blaxill commented 3 years ago

Is this what was causing the failure on the test3 test vector?

test3 would have failed anyway as there was a bug in the core which is now fixed.

Do you know why doesn't it happen with the other 2-block test?

It doesn't happen in other 2-block test, because the provided input sequence fits in the first block, the second block contains only the padding&length from the padder which schedules itself correctly.