search

project-owlly / site

🦉 owlly enables the secure and easy electronic signing, validation and counting of popular initiatives and referendums for campaign platforms and offers a holistic e-collecting approach for Switzerland.
https://owlly.ch
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

issue: onClick & github actions failed #15

Closed sansan88 closed 4 years ago

sansan88 commented 4 years ago

Actions failed.

https://github.com/project-owlly/site/actions/runs/276292862

jonarivado commented 4 years ago

I looked at the error messages and found an answer on stackoverflow. I hope this should fix the building issue.

peterpeterparker commented 4 years ago

@jonarivado I provided a PR https://github.com/project-owlly/site/pull/17 to try to fix it

  1. I was wrong it was not the reserved word but the fact that onClick was not declared at all. In the related home.page.ts there was no such function.

  2. The footer component is part of a module calls components.module.ts. In this module there was no import of the Ionic component and therefore the ion- components were not resolved. A component is always attached to a module, root or any other level, which import a certain list of components.

peterpeterparker commented 4 years ago

Build is solved, actions failed because of Firebase deploy

jonarivado commented 4 years ago
  1. Yes exactly, I forgot to declare it as I wasn't getting any errors (because I never klicked on the button)
  2. Alright, thank you for the info!
peterpeterparker commented 4 years ago

My pleasure!