Closed ang2887 closed 2 months ago
Please, Arad, let me know if there are any issues with the code and what could be done better.
@ang2887 reviewing
Thanks )
On 14 Jun 2024, at 16:22, aradmschool @.***> wrote:
@ang2887 https://github.com/ang2887 reviewing
— Reply to this email directly, view it on GitHub https://github.com/project-palooza/causal_inference/pull/10#issuecomment-2168262916, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHTP5EQTAY3UU3Z474WG5YDZHMDDBAVCNFSM6AAAAABJKBZVYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRYGI3DEOJRGY. You are receiving this because you were mentioned.
hey -- nice job! I made a slight adjustment then merged. instead of having the power calculation in the notebook -- i isolated it to a script.
Thank you!
Next time I’ll try to do this by myself.
On Jun 15, 2024 at 2:37 PM, <aradmschool @.***)> wrote:
hey -- nice job! I made a slight adjustment then merged. instead of having the power calculation in the notebook -- i isolated it to a script.
— Reply to this email directly, view it on GitHub (https://github.com/project-palooza/causal_inference/pull/10#issuecomment-2169637494), or unsubscribe (https://github.com/notifications/unsubscribe-auth/BHTP5EXV4PCVUMWCSPOEHYDZHQ7RFAVCNFSM6AAAAABJKBZVYWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGYZTONBZGQ). You are receiving this because you were mentioned.Message ID: @.***>
I did not know what was the best way to submit the code, so I decided to submit two versions: