Remove redundant controller endpoint

project-receptor / python-receptor

Project Receptor is a flexible multi-service relayer with remote execution and orchestration capabilities linking controllers with executors across a mesh of nodes.

Other

32 stars 21 forks source link

Remove redundant controller endpoint #160

Closed ghjm closed 4 years ago

ghjm commented 4 years ago

Right now if you run receptor controller, the differences from receptor node are:

The --server-disable option to suppress starting a listener is unavailable
You cannot specify --peer options to make outbound connections
You cannot specify a keepalive interval to send keepalives
You can specify a socket_path option, but it doesn't actually do anything

Intuitively, you would expect that receptor controller is somehow a different mode of operation or does something that receptor node doesn't do, but this is not actually the case.

elyezer commented 4 years ago

Once this is merged I will basically need to replace controller with node for places I used to start as a controller. Is that correct?

If that is correct, then the perf tests will need to be updated since it starts receptor as controller.

ghjm commented 4 years ago

Yes, that is correct @elyezer. If this PR is accepted, then everything that runs receptor controller will need to switch to receptor node.

I would put in an alias that makes the two strictly equivalent, but I can't see a reasonable way to do that with the way config.py is currently structured.

elyezer commented 4 years ago

@ghjm thanks for the clarification, I can work on updating the tests if this PR gets accepted.

jhjaggars commented 4 years ago

Everything is node.

All hail Node!