search

project-receptor / python-receptor

Project Receptor is a flexible multi-service relayer with remote execution and orchestration capabilities linking controllers with executors across a mesh of nodes.
Other
32 stars 21 forks source link

Receptor ping --count 0 implies --delay 0 #209

Open ghjm opened 4 years ago

ghjm commented 4 years ago

receptor ping foo uses the default of four pings with a one-second delay. receptor ping foo --count 0 unexpectedly pings as fast as possible, with no delay. receptor ping foo --count 0 --delay 10 ignores the delay and still pings as fast as possible.

Expected behavior: delay should be one second unless specified, and when specified, should be respected.

elyezer commented 4 years ago

Do we want to set a minimum delay allowed? Like, do we want to support no delay pings and maybe overload the mesh?

ghjm commented 4 years ago

I think it's useful to allow flood pings for certain troubleshooting scenarios, but you should have to do it explicitly with --delay 0.

elyezer commented 4 years ago

That is a good point and I agree with it.

ghjm commented 4 years ago

Fixed by https://github.com/project-receptor/receptor/pull/223