project-rig / rig

A collection of tools for developing SpiNNaker applications.
GNU General Public License v2.0
4 stars 0 forks source link

Disallow repeated keys and masks #192

Closed mundya closed 9 years ago

mundya commented 9 years ago

build_routing_tables raises an exception if multiple nets with the exact same key and mask would cause packets to become duplicated at any node; this is generally an indication that the underlying net should be being treated as a multisource net.

This is option (3) from #153.

Clearly this is a somewhat contentious change, for example it will break nengo_spinnaker as stands.

mossblaser commented 9 years ago

This LGTM, aside from the exception message and type check in the tests!

As mentioned offline and in #153, the issue of N:M nets is going to need to be considered properly in the near future.

mundya commented 9 years ago

Bump.