Changes to RegionTree for FFCS

project-rig / rig

A collection of tools for developing SpiNNaker applications.

GNU General Public License v2.0

4 stars 0 forks source link

Changes to RegionTree for FFCS #210

Closed mundya closed 8 years ago

mundya commented 8 years ago

Minimising flood-fill regions is hard. This commit changes the RegionTree structure such that it:

Will generate region and core masks in the order required by SCAMP (that is, in increasing order of region << 32 | coremask)
Has some knowledge of cores, and so can perform a bit more minimisation internally.

mossblaser commented 8 years ago

This looks reasonable to me though I think I'd better check through it again on monday if that is OK?

mundya commented 8 years ago

This looks reasonable to me though I think I'd better check through it again on monday if that is OK?

No worries, this is hardly an urgent change!

mossblaser commented 8 years ago

Right; aside from the "x" comment; this looks correct to me, even if I can't quite work out why it should be better than the previous technique per-se. Feel free to merge at your discretion.

mundya commented 8 years ago

This should be ready for re-review or merge, up to you @mossblaser

mossblaser commented 8 years ago

Aside from the above question, this LGTM!