Add free commands - Githubissues

project-rig / rig

A collection of tools for developing SpiNNaker applications.

GNU General Public License v2.0

4 stars 0 forks source link

Add free commands #229

Closed mundya closed 8 years ago

mundya commented 8 years ago

[x] Free SDRAM by pointer
[x] Free file-like views of SDRAM
[x] ~~Free routing table entries~~ we can already remove all routing table entries associated with an app_id (see MachineController:clear_routing_table_entries).

Beat you to the punch @neworderofjamie.

neworderofjamie commented 8 years ago

Hurrah!

mossblaser commented 8 years ago

Freeing stuff LGTM :). Following offline discussion:

File-likes should probably be free-able, though only the 'root' file-like should actually be allowed to do the freeing.
A check should be performed to ensure the memory associated with a file-like is not freed before all read/write operations.

mundya commented 8 years ago

Note: this PR now also removes the buffering of file-like views of SDRAM (#190)

mossblaser commented 8 years ago

Minus failing tests, this looks rather sensible!

mundya commented 8 years ago

@neworderofjamie - does this seem OK to you? Particularly the loss of buffering and the requirement that only the MemoryIO returned by sdram_alloc_as_filelike (and not any gained by slicing) can be freed.

neworderofjamie commented 8 years ago

I think you convinced me of the need to remove buffering so I have resigned myself to that; and not freeing slices seems an entirely logical restriction on freeing memory allocated using sdram_alloc_as_filelike

mossblaser commented 8 years ago

Sounds like this is rigged then! Merge at will, @mundya.

mundya commented 8 years ago

I've just squashed that down a bit, I'll merge when Travis is happy. Thanks @mossblaser