Closed mossblaser closed 8 years ago
MachineController.boot() may be called without arguments (giving a width and height result in a deprecation warning and the values being ignored.
Given that this is a major version bump I'd be happy skipping the deprecation stage and just remove those arguments.
Other than that this all sounds awesome and I'll review!
Given that this is a major version bump I'd be happy skipping the deprecation stage and just remove those arguments.
I'm leaving them since a good number of rig scripts are floating around which I would wish to remain working. Plus it means that doing pip upgrade will allow nengo_spinnaker/Pinus-Rigida to benefit from hardware black-listing, faster booting, and general SC&MP robustness improvements the second this is released without modification.
I'm leaving them since a good number of rig scripts are floating around which I would wish to remain working. Plus it means that doing pip upgrade will allow nengo_spinnaker/Pinus-Rigida to benefit from hardware black-listing, faster booting, and general SC&MP robustness improvements the second this is released without modification.
Fair enough, thanks.
NB: this fixes #131. I suggest de-milestoning the other 1.0 milestones since they are not blocking and all have potential implementations with no breaking changes.
I'm very pleased at how much this change simplifies things! This pretty much LGTM!
I propose that once merged this marks v1.0.0 of Rig which we really should have reached ages ago...
and
I suggest de-milestoning the other 1.0 milestones since they are not blocking and all have potential implementations with no breaking changes.
Agreed to both.
2f0c20f39561dd7c795d02c8b206a66318653167 looks fine to me.
I propose that once merged this marks v1.0.0 of Rig which we really should have reached ages ago...
This commit migrates over to a release-candidate of SpiNNaker Tools 2.0.0 which includes and new SC&MP which notably no longer needs to know the size of the machine when booting nor requires that chip (0, 0) exist at all.
NOTE This commit includes an unofficial SpiNNaker Tools release candidate version of SC&MP, sark.struct and test application binary. These should be rebuilt using the officially released SpiNNaker Tools package before final release of these changes to Rig.
Changes: