search

project-rig / rig

A collection of tools for developing SpiNNaker applications.
GNU General Public License v2.0
4 stars 0 forks source link

Improve type cast utilities #245

Closed mundya closed 8 years ago

mundya commented 8 years ago

New methods float_to_fp and fp_to_float work with signed and unsigned values as expected. New methods and NumpyFloatToFixConverter can now have negative numbers of fractional bits or more fractional bits than can be represented in the result - as requested by @neworderofjamie.

mundya commented 8 years ago

Should replace #240.

neworderofjamie commented 8 years ago

Thank god, I had just beaten pytest into submission and doctest had raised it's magical head...

On 13 May 2016 at 12:02, Andrew Mundy notifications@github.com wrote:

Should replace #240 https://github.com/project-rig/rig/pull/240.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/project-rig/rig/pull/245#issuecomment-219013669

neworderofjamie commented 8 years ago

This looks way better to me! Will merge once the tests pass n'shit then can you make a release @mossblaser ? It would be nice to make a pynn_spinnaker release depending on a version of rig which won't complain in (to the user) mysterious ways

mundya commented 8 years ago

@neworderofjamie - I think I'll need to fix a doctest, and squash, but I'll let you know when I've done that. Sorry for being zlow.

mossblaser commented 8 years ago

Sounds good! I'll release once this is all reviewed and merged!

neworderofjamie commented 8 years ago

Tested against pynn_spinnaker, works great