search

project-rig / rig

A collection of tools for developing SpiNNaker applications.
GNU General Public License v2.0
4 stars 0 forks source link

Add Reverse Cuthill-McKee (RCM) placement algorithm #254

Closed mossblaser closed 8 years ago

mossblaser commented 8 years ago

This simple breadth-first-search-like sequential placer can be found in the software placement literature and is believed to perform a reasonable job of placing pipeline-like things.

Sorry to drop you in reviewing this clearly thesis-specific change @mundya ...

mundya commented 8 years ago

No test for the placer yet?

Sorry!

mundya commented 8 years ago

Looks good to me (not sure I fully understand) apart from the comments above.

mossblaser commented 8 years ago

No test for the placer yet?

There is a generic test suite for placement algorithms to which this placer has been added: https://github.com/project-rig/rig/pull/254/files#diff-e60413cd5d0cfb7adc8ce7a7f61c02e7R63 This suite should be sufficient, especially since this placer is really just a wrapper around the seqential placer in which the order in which vertices/chips are assigned is determined (in this placer) by the RCM algorthm.

mundya commented 8 years ago

Cool, I think I understand this now, thank you!

mundya commented 8 years ago

Rigged