project-rig / rig

A collection of tools for developing SpiNNaker applications.
GNU General Public License v2.0
4 stars 0 forks source link

Fix sequential placer SameChipConstraint edge-cases. #255

Closed mossblaser closed 8 years ago

mossblaser commented 8 years ago

Prior to this fix, if a placement problem contains overlapping or duplicate-containing SameChipConstraints, the sequential placer (and thus all other placers built on it, e.g. hilbert and breadth_first) would fall over.

Though these smell of 'edge-case' they are actually very common in PyNN SpiNNaker's netlists... The generic placer test suite has been updated with a test case which include these behaviours..

mundya commented 8 years ago

LGTM!