search

project-robius / robrix

A Matrix chat client written in pure Rust using the Makepad UI toolkit and the Robius app dev framework
MIT License
67 stars 11 forks source link

Complete the basic functions of the search bar #135

Closed tyreseluo closed 1 week ago

tyreseluo commented 1 week ago

More content may be needed, only simple room list based filtering has been implemented so far, removal of icon and other content is under construction.

tyreseluo commented 1 week ago

Hi @kevinaboos, thank you very much for your comments, I will keep changing and exporting and keep improving myself. Until I am able to complete and think about this project independently. This issue will be back to you here within the week. Thanks for your hard work.

kevinaboos commented 1 week ago

oh, you don't have to close the issue! I mean, you can close it if you want, or if you prefer to open a new issue that's fine too. But it just needs some moderate restructuring of the way that you store the rooms that match the search terms.

tyreseluo commented 1 week ago

oh no! sorry, i made a mistake 😅. I discard the changes, when i pull the latest code, I don't want to close it. I'd like to keep working on it. i will keep solve this issue!

kevinaboos commented 1 week ago

No worries! I'll re-open it.

Let me know when you're ready for another review. Also, kindly avoid force pushing, as it removes my review comments.

kevinaboos commented 1 week ago

Re-opening

kevinaboos commented 1 week ago

Hmm, it won't let me re-open it.

tyreseluo commented 1 week ago

It's not a big deal. I'm working on this issue on the new UI and will bring it up for review this week. Thanks for the advice.🤝🤝🤝