search

project-robius / robrix

A multi-platform Matrix chat client written in pure Rust using the Makepad UI toolkit and the Robius app dev framework
MIT License
93 stars 17 forks source link

Move searchbar's position to sidebar #200

Closed Demolemon11 closed 1 week ago

Demolemon11 commented 3 weeks ago

Before:

Screenshot from 2024-10-13 10-14-21

After:

Screenshot from 2024-10-13 10-37-04

joulei commented 2 weeks ago

@Demolemon11 having the search bar at the top of the app is actually a design decision, we're currently discussing with a designer what this will look like. Furthermore, there's already a PR adding a local search to filter out the rooms on left panel: https://github.com/project-robius/robrix/pull/159. Also, there's a limitation with Makepad's implementation of the window title in some platforms where if you attempt to move the tabs around (without having some other space above like the search bar), the whole window will move instead of the tab. Currently that spacebar is a good filler for that space.

TLDR: I don't think we should do this change right now. Let's us solve some of the issues around it first. (we also have some things to discuss like what will the rooms sidebar search look like with added People and Channels sections).

Demolemon11 commented 2 weeks ago

Got it, thanks so much.

kevinaboos commented 1 week ago

Agreed, I don't think this direction is desirable at this moment. Apologies, but thanks for the work!