project-robius / robrix

Robrix: a multi-platform Matrix chat client written in Rust using the Makepad UI toolkit and the Robius app dev framework
MIT License
107 stars 18 forks source link

Apply a yellow background highlight to messages that mention the current logged-in user #240

Closed ZhangHanDong closed 2 weeks ago

ZhangHanDong commented 2 weeks ago

Fixed issue #299 . Apply a yellow background highlight to messages that mention the current user.

Screenshot 2024-11-07 at 00 36 21 Screenshot 2024-11-07 at 01 01 46
ZhangHanDong commented 2 weeks ago

Matrix SDK offers an API to obtain the users mentioned by a given message, also cover the use case of a replied-to message.

I also modified the background color.

Screenshot 2024-11-07 at 13 44 35
ZhangHanDong commented 2 weeks ago

I adjusted the transparency, and now it looks like this. Screenshot 2024-11-07 at 14 12 09

kevinaboos commented 2 weeks ago

Matrix SDK offers an API to obtain the users mentioned by a given message, also cover the use case of a replied-to message.

great, that makes things easy!

kevinaboos commented 2 weeks ago

I adjusted the transparency, and now it looks like this. Screenshot 2024-11-07 at 14 12 09

Maybe my monitor is bad, but I can't really see the highlighted effect there. One of the first screenshots you provided actually had the perfect mix of yellow color, imo. We should go with that one: https://private-user-images.githubusercontent.com/27893/383655701-fc05db22-af50-4a4d-ae7a-41f574c43f59.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzA5NjA2ODUsIm5iZiI6MTczMDk2MDM4NSwicGF0aCI6Ii8yNzg5My8zODM2NTU3MDEtZmMwNWRiMjItYWY1MC00YTRkLWFlN2EtNDFmNTc0YzQzZjU5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDExMDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMTA3VDA2MTk0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRiMTNmOTA2OTk4MWE4MzVlMGUzZGIyNTkwZmE3NzgyNTAyNTZhNjkyZDI2OTNlOTgyYWM5Yzk5NDkxNmMzOGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.JVJXMRDW1V47J_CT9orJ4pmhcQT-WVleHuQfXlTiiVg

ZhangHanDong commented 2 weeks ago

It should now display the effect shown in the image, and I’ve also added a left border effect, similar to what Discord has.

Screenshot 2024-11-07 at 14 50 59