Closed Demolemon11 closed 2 weeks ago
Are you sure? I am able to see the transition from Unknown --> Unverified when starting Robrix, and then after I complete the verification process, I also observe the transtion from Unverified --> Verified.
What steps are you taking such that verification states are not updated? Perhaps you can share a quick screen recording video or something.
I just tried the entire verification procedure again, and it worked as expected.
Grepping for "verification state", you can see the state updates here:
src/verification.rs:22:5 - Initial verification state is Unknown
src/verification.rs:25:13 - Received a verification state update: Unverified
src/verification.rs:25:13 - Received a verification state update: Unverified
src/verification.rs:25:13 - Received a verification state update: Unverified
src/verification.rs:25:13 - Received a verification state update: Verified
src/verification.rs:25:13 - Received a verification state update: Verified
src/verification.rs:25:13 - Received a verification state update: Verified
src/verification.rs:25:13 - Received a verification state update: Verified
If you're not able to reproduce this, then perhaps your matrix account keys weren't set up or preserved correctly? Are you able to self-verify other devices using other non-Robrix clients?
This func: https://github.com/project-robius/robrix/blob/185459f8cfb6443e38c57149c6d7afd796d770e8/src/verification.rs#L20
It seems not work well in here: https://github.com/project-robius/robrix/blob/185459f8cfb6443e38c57149c6d7afd796d770e8/src/sliding_sync.rs#L972 I guess it seems the verificating is too earily to be not proper.
You can verify your device & session, and the log is always
Unknown
: https://github.com/project-robius/robrix/blob/185459f8cfb6443e38c57149c6d7afd796d770e8/src/verification.rs#L22This pr just make it work , however, I know where I modified is not in your expectation, but it just is a draft. I have not loaded svgs yet, I just want to prove where there call the func is not working and shall modify it later.
Fixes #241