Closed tyreseluo closed 2 weeks ago
@kevinaboos So I'm only adding window and mac shortcuts for sending messages now. Wait until we can edit the message, then do a carriage return to add a new line.
@kevinaboos But if it is added to the TextInput
component in makepad does it affect the situation in other projects when they also use the relevant shortcut, but not ctrl + enter
or logo + enter
.But either way, for now it's just an option for the current situation. Later on it will still allow user to do customization as well.
@kevinaboos But if it is added to the
TextInput
component in makepad does it affect the situation in other projects when they also use the relevant shortcut, but notctrl + enter
orlogo + enter
.But either way, for now it's just an option for the current situation. Later on it will still allow for customization as well.
No no, to clarify what I meant, the TextInput
widget should emit an action that includes the modifier keys held down whilst the Return
key was pressed. I will add this to Makepad later.
oh,ok, I misunderstood.
So I implemented this in Makepad, but on second thought I don't think it's necessary, as it's not much of an improvement over what you've done in this PR.
Just as a heads up, I implemented a different improvement to Makepad and am now using it in #252; this makes the code from this PR slightly more efficient while also avoiding platform-specific code within the Robrix app itself (which is one of our goals for makepad/robius)
You actually right. Thanks.
Shift
+Return
inserts a new line, as handled by Makepad'sTextInput
widget.Return
by itself will currently do nothing.Ctrl + Return
orCommand ⌘
+Return
will send the message, which behaves just like clicking theSend
button.