project-rubika / issues

6 stars 0 forks source link

Tradeskills doesn´t check skill requirements #738

Closed thordenm closed 1 month ago

thordenm commented 4 months ago

Describe the bug You can tradeskill things, which your character shouldnt be able to. I.e. a lvl 1 char can create lvl 200 carb armour. (i have only tested with crawler armour and carb armour)

To Reproduce Steps to reproduce the behavior: Be on a character which has less then 337 mech engineering.

  1. /item 162220 162220 75
  2. /item 245213 245213 75
  3. combine the two or use the tradeskill kit ui element, if you like pain

Expected behavior Should not allow the two to be combined.

Carbonum sheets: .item 156017 156016 ql

RaggyLP commented 3 months ago

Confirmed, tested by using a Level 1 character with 7 ME. Both with the MRR + Crawler skin and also with an Implant. It would appear currently checks against Tradeskills are not currently implemented.

prkdrake commented 1 month ago

Should be more or less fixed - the numbers aren't exactly the same as on live and might be off by one or two here or there, and also there's some weird stuff going on with which skills are checked, but that can be raised as a seperate issue I think.

RaggyLP commented 1 month ago

image image image

Confirmed fixed. Tested both with no IP, IP buffed and unbuffed. Tradeskill for the above now respects the tradeskill requirements for this particular recipe. Closing this as fixed for now from 25/07/24.