search

project-serum / serum-dex-ui

Example implementation of a UI for the Serum DEX
Other
356 stars 538 forks source link

Use `@solana/wallet-adapter-react` for compatibility with Mobile Wallet Adapter and the Wallet Standard #157

Closed steveluscher closed 2 years ago

steveluscher commented 2 years ago

In this PR we replace a custom wallet adapter solution with @solana/wallet-adapter-react. The main benefit of doing so is that Serum DEX UI thusly gets the following for free:

  1. The ability to connect to any mobile wallet app that supports the Solana Mobile Stack Mobile Wallet Adapter Protocol
  2. The ability to connect to any desktop wallet that supports the Solana Wallet Standard.

You can read much more about the wider effort to upgrade the entire ecosystem of Solana web apps at: https://github.com/solana-labs/wallet-adapter/issues/604

Test plan

Mobile, with mobile wallet

https://user-images.githubusercontent.com/13243/197298293-3e6763ea-7e21-43e5-83d9-5533aa41b15d.mp4

Desktop, with desktop wallets

https://user-images.githubusercontent.com/13243/197298329-514e67c7-3014-4f23-9c92-20aa60ecb008.mov

steveluscher commented 2 years ago

Lisbon Hacker House starts tomorrow. Anything more you need here @sayantank, or is this good to ship?

sayantank commented 2 years ago

Lisbon Hacker House starts tomorrow. Anything more you need here @sayantank, or is this good to ship?

Hey @steveluscher, apologies for the delay, another team member was looking into the PR and its ready to be merged. I'll merge it rn!