project-serum / serum-dex

Project Serum Rust Monorepo
https://projectserum.com
Apache License 2.0
629 stars 329 forks source link

Update clap to v3.1.6: clap version used in dex has unstable API #221

Closed KirillLykov closed 2 years ago

KirillLykov commented 2 years ago

Currently used version of clap is 3.0.0-beta.1, see https://github.com/project-serum/serum-dex/blob/a3b4cf71193611fd96af9b277db93a505d581648/dex/crank/Cargo.toml#L14

This leads to compilation error when building downstream projects in solana: build log

Why it happens: because we trying to update clap to version 3.1.5 and version resolution works such a ways that it picks the latest version from Cargo.lock with the same major release. It is assumed that all the crates with the same major have compatible API which is not the case for clap's beta. (please, correct me if I'm wrong)

KirillLykov commented 2 years ago

resolved