`payer` refer to different things in `serum-js` and `crank`

project-serum / serum-js

JavaScript client library for interacting with the Project Serum DEX.

82 stars 33 forks source link

`payer` refer to different things in `serum-js` and `crank` #19

Closed leofisG closed 3 years ago

leofisG commented 4 years ago

In serum-js README the payer is the public key address that holds the SPL token (in the case of bid order placement it will hold quote token), however, in crank the payer means the wallet account. See here.

My understanding is based on Account (solana-web3 type) generally correspond to Keypair(solana-rust-sdk). And PublicKey (solana-web3 type) correspond to Pubkey (solana-rust-sdk).

It will be nice if the naming can be unified to avoid some confusion.

armaniferrante commented 3 years ago

This repository has moved to https://github.com/project-serum/serum-ts/tree/master/packages/serum. Please migrate this issue over, if desired.